Support for awsvpc networking mode in ECS #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jahkeup
reviewed
Dec 17, 2020
srgothi92
reviewed
Dec 22, 2020
This push rebases on top of the current tip of |
|
Closed
jahkeup
reviewed
Apr 1, 2021
samuelkarp
force-pushed
the
awsvpc
branch
2 times, most recently
from
16beb8d
to
cd3e662
Compare
samuelkarp
changed the title
webern
approved these changes
Apr 12, 2021
jahkeup
reviewed
Apr 13, 2021
samuelkarp
commented
Apr 13, 2021
samuelkarp
commented
Apr 13, 2021
samuelkarp
commented
Apr 13, 2021
bcressey
approved these changes
Apr 14, 2021
jahkeup
approved these changes
Apr 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#1077
Description of changes:
This pull request adds support for the
awsvpcnetworking mode to the Bottlerocketaws-ecs-1variant.The
awsvpcnetworking mode is enabled through the use of several CNI plugins that are used in combination. While the CNI plugins are stored in two separate git repositories (amazon-ecs-cni-plugins and amazon-vpc-cni-plugins), they are effectively tightly coupled to the ECS agent; the ECS agent repository includes the plugins as git submodules and is only ever tested with the exact versions of the plugins included as submodules. Because of this tight coupling, the CNI plugins are included as part of theecs-agentspec file; when any one of these source files are updated all should be.Testing done:
cargo make -e BUILDSYS_VARIANT=aws-ecs-1-versionargumentawsvpcmode on at2.microawsvpcmode on ac5.large, exercising ENI trunkingTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.