Containerd backports for shim logs and signal forwarder issues #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zmrow
force-pushed
the
containerd-backport
branch
from
26108ea
to
4b2a70f
Compare
|
^ Fixes the comments in |
zmrow
force-pushed
the
containerd-backport
branch
from
4b2a70f
to
c848f1a
Compare
|
^ Fix typo |
tjkirch
approved these changes
Nov 16, 2020
bcressey
reviewed
Nov 16, 2020
Backport the patch from containerd/containerd#4543 which fixes SIGURG issues with go 1.14+.
Backort the patch from containerd/containerd@42f3871 which ensures that fifos are consumed and do not fill up.
zmrow
force-pushed
the
containerd-backport
branch
from
c848f1a
to
9e18bc7
Compare
|
^ Split the signal forwarder patch into 2 patches as per @bcressey |
bcressey
approved these changes
Nov 16, 2020
samuelkarp
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N/A
Description of changes:
Backport a few upstream
containerdfixes for for shim logs and signal forwarder issuesTesting done:
aws-k8s-1.17/x86_64)Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.