Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aws-k8s-1.18 variant with Kubernetes 1.18 #1150

Merged
merged 2 commits into from
Oct 7, 2020

Conversation

tjkirch
Copy link
Contributor

@tjkirch tjkirch commented Oct 6, 2020

Description of changes:

@sanu11 did the addition of the variant, and I helped track down some testing.

For reference, the addition of 1.17 was in #973.
This one was more straightforward; the only changes:

  • We no longer need the patch for aws-sdk-go to support IMDSv2, it's in k8s 1.18.
  • We learned that the k8s version skew policy isn't what we thought, so I have another commit fixing the supported control plane versions for each variant in variants/README.md.

Testing done:

  • @sanu11 and I both confirmed conformance testing passed on x86, and I confirmed on aarch64.
  • Pods run OK.
  • I compared system logs and found nothing new.
  • I compared kubelet logs and found nothing wrong, however note the next paragraph.

CSI changed a bit in Kubernetes 1.18 (I believe related to kubernetes/kubernetes#84814) and it means that you can't use CSI from a 1.18 node against a 1.17 cluster. I was able to make a 1.18 cluster and confirm that CSI does work.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

sanu11 and others added 2 commits October 6, 2020 10:59
Co-authored-by: Tom Kirchner <tjk@amazon.com>
Per https://kubernetes.io/docs/setup/release/version-skew-policy/
"kubelet must not be newer than kube-apiserver, and may be up to two minor
versions older."
@tjkirch tjkirch marked this pull request as ready for review October 7, 2020 16:56
@tjkirch
Copy link
Contributor Author

tjkirch commented Oct 7, 2020

Updated the description. I was able to confirm that CSI works with a 1.18 node against a 1.18 cluster, just not against a 1.17 cluster. (Kubernetes doesn't support using a newer kubelet against an older cluster, as mentioned above, so this seems fine.)

@tjkirch tjkirch merged commit b5fd55f into bottlerocket-os:develop Oct 7, 2020
@tjkirch tjkirch deleted the k8s-1.18 branch October 7, 2020 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants