Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-ecs-1: enable awslogs execution role support #1044

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sources/api/ecs-settings-applier/src/ecs.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ struct ECSConfig {

#[serde(rename = "SELinuxCapable")]
selinux_capable: bool,

#[serde(rename = "OverrideAWSLogsExecutionRole")]
override_awslogs_execution_role: bool,
}

// Returning a Result from main makes it print a Debug representation of the error, but with Snafu
Expand Down Expand Up @@ -83,6 +86,10 @@ fn run() -> Result<()> {

// SELinux is always available
selinux_capable: true,

// Always supported with Docker newer than v17.11.0
// See https://github.com/docker/engine/commit/c7cc9d67590dd11343336c121e3629924a9894e9
override_awslogs_execution_role: true,
..Default::default()
};
if let Some(os) = settings.os {
Expand Down