Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrations: migrate new cluster-domain setting #1036

Merged

Conversation

etungsten
Copy link
Contributor

Add a migration for migrating the new cluster-domain setting

Issue number:
N/A

Description of changes:

Author: Erikson Tung <etung@amazon.com>
Date:   Thu Aug 13 09:32:04 2020 -0700

    migrations: add `cluster-domain` setting
    
    Add a migration for migrating the new `cluster-domain` setting

Testing done:
With a local datastore:
Backward migration from 0.5.0 datastore

$ VARIANT=aws-k8s-1.17 cargo run -- --source-datastore ~/thar/testing/ds/current --target-datastore ~/thar/testing/ds/next-backward --backward
...
Found no settings.kubernetes.cluster-domain to remove
Removed settings.kubernetes.cluster-domain, which was set to '"cluster.local"'
etung in migrations/v0.5.0/add-cluster-domain on 🌱 develop [⇡$!?] via 🦀 v1.45.2 took 9s

Forward migration from there:

$ VARIANT=aws-k8s-1.17 cargo run -- --source-datastore ~/thar/testing/ds/next-backward --target-datastore ~/thar/testing/ds/next-forward --forward
    Finished dev [unoptimized + debuginfo] target(s) in 0.17s
     Running `/home/ANT.AMAZON.COM/etung/thar/PRIVATE-thar/sources/target/debug/add-cluster-domain --source-datastore /home/ANT.AMAZON.COM/etung/thar/testing/ds/next-backward --target-datastore /home/ANT.AMAZON.COM/etung/thar/testing/ds/next-forward --forward`
AddSettingsMigration(["settings.kubernetes.cluster-domain"]) has no work to do on upgrade.
AddSettingsMigration(["settings.kubernetes.cluster-domain"]) has no work to do on upgrade.

No work done as expected on upgrade.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Add a migration for migrating the new `cluster-domain` setting
@etungsten etungsten merged commit 72c107d into bottlerocket-os:develop Aug 13, 2020
@etungsten etungsten deleted the cluster-domain-migration branch August 13, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants