schnauzer: add a helper for ecr repos #1032
Conversation
sources/api/migration/migrations/v0.5.1/ecr-helper-admin/src/main.rs
Outdated
Show resolved
Hide resolved
|
Can/should we combine this migration with #1030? |
It's possible, but I'm not sure I'll be ready in time. I need to test this with confidence, which would be today (8/12) EOD/late at best. |
Fixed some wording, have not addressed PR comments yet. |
separates the refactors from the new code (two commits) |
Rebase develop with conflict resolution over the container version bumps. |
Change design to return the whole fqdn instead of registry and region separately. Also addressed all other PR comments to-date. |
Addresses @tjkirch comments: fixup refactor commit to remove unrelated errors, use 0.5.1 in the test string to make it more clear when this change took place. |
Rebase, resolve conflict for admin container version bump. |
Missed a spot with the admin container bump. |
Bump the container version in a comment that was missed. |
|
Finished testing, exiting draft status... |
Issue number:
N/A
Description of changes:
In order to expand Bottlerocket to certain AWS regions, we need to change the way the ECR URL is constructed. Initially we intended to use a single ECR registry ID. For some regions this will not work. So we added a helper function and a map to Schnauzer so that we can look up the registry ID from a map.
Additionally, this allows us to introduce the concept of a fallback ID/region pair. This will prove useful if a new region is added and, for example, an older version of Bottlerocket tries to run on it.
NOTE we need to update the migration versionized-directrory and the container tag versions that it hard-codes based on where things stand when we release these changes.
Testing done:
Ran an instance in me-south-1, the admin container worked, and I found these container URLs in the settings:
Created a fake future version of Bottlerocket and ran an upgrade in us-west-2. Observed that the migrations ran and the URLs were still good.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.