Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address feedback about cargo make ami #1028

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Address feedback about cargo make ami #1028

merged 2 commits into from
Aug 12, 2020

Commits on Aug 11, 2020

  1. Separate publish tasks 

    If you just want to build images, you don't need to build the pubsys tool
first, only buildsys.  This change splits the tasks so that builds only need to
depend on buildsys.

Similarly, AMI and repo builds only need to depend on pubsys, not buildsys.
`cargo make` currently rebuilds images each run.  If you want to build repos
or build/copy AMIs based on a previous image build, you don't want to wait for
image rebuilds, and you don't want to use different files - you want to use the
same image files you had.  This change makes the ami and repo tasks depend only
on pubsys and sources, and checks for image file existence internally.  (The
image file names include version and commit, so you can't accidentally use an
old build.)

This will also apply for `cargo make ssm`, where timing is even more critical.

Co-authored-by: Zac Mrowicki <mrowicki@amazon.com>
Co-authored-by: Tom Kirchner <tjk@amazon.com>
    @zmrow @tjkirch
    zmrow and tjkirch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4d549bf View commit details
    Browse the repository at this point in the history

  2. pubsys: default AwsConfig so it's not required 

    Have serde default `aws.region` so the user does not have to have an empty
`aws.region` table if they have no region-specific configuration.

Have serde default `aws.regions` in case the user only wants to specify regions
on the command line with `PUBLISH_REGIONS`.

Derive Default on AwsConfig now that all sections of `aws` in Infra.toml are
optional, so the user doesn't need an empty `[aws]` section if they intend to
use default credential mechanisms and specify `PUBLISH_REGIONS`.

Co-authored-by: Zac Mrowicki <mrowicki@amazon.com>
Co-authored-by: Tom Kirchner <tjk@amazon.com>
    @zmrow @tjkirch
    zmrow and tjkirch committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    4c22b4d View commit details
    Browse the repository at this point in the history