Add buildpack/builder/stacks for Rust #95
Conversation
| #!/usr/bin/env bash | ||
| set -eo pipefail | ||
|
|
||
| if [[ ! -f Cargo.toml ]] ; then |
There was a problem hiding this comment.
Soon I think we should change all of the buildpacks to look first for a func.yaml file.
There was a problem hiding this comment.
if there wasn't a func.yaml file, how would func know which builder to even run?
There was a problem hiding this comment.
Exactly - and if there's not a func.yaml, then it's probably not a function project
There was a problem hiding this comment.
I'm thinking it's a redundant, superfluous check because of course there's a func.yaml there because that's the only possible way func would've invoked this builder in the first place...
But you must be thinking that the buildpack might be invoked by something other than func so we need to check for func.yaml to prevent... what exactly? Sorry for being dense.
| [stack] | ||
| id = "dev.boson.stacks.rust" | ||
| build-image = "quay.io/boson/faas-stack-build:rust-{{VERSION}}" | ||
| run-image = "quay.io/boson/faas-stack-run:rust-{{VERSION}}" |
There was a problem hiding this comment.
Now that we have multiple buildpacks that result in a binary for runtime execution, we should probably have a single tag for these vs. boson/faas-stack-run:rust-{{VERSION}} and boson/faas-stack-run:go-{{VERSION}} which are bit for bit the same image outside of the tag.
Perhaps this should point to quay.io/boson/faas-stack-run:ubi8-minimal-{{VERSION}}. It has all of the necessary metadata, and we can avoid adding another tag to the image.
| @@ -0,0 +1,8 @@ | |||
| ARG version=tip | |||
There was a problem hiding this comment.
See my note above about using just the ubi8-minimal-{{VERSION}} image as the run image for Rust.
|
Before making release it might be good to create |
A pretty simple first attempt here, using the cargo/rust packages available in the Red Hat ubi repo (rustc v1.49.0)
Possible enhancements include rust version selection using
rustupand non-linked binaries using a musl target.