Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python-version): Updated python to 3.12 and dependencies #123

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

aniketsalve22
Copy link
Collaborator

@aniketsalve22 aniketsalve22 commented Apr 4, 2024

Fixed package versions to make doxysphinx compatible with python 3.12

Signed-off-by: Aniket Dilip Salve <aniketdilip.salve@bosch.com>
Signed-off-by: Aniket Dilip Salve <aniketdilip.salve@bosch.com>
@winterz
Copy link

winterz commented Apr 24, 2024

  1. can this be merged so we can get doxysphinx for python3.12? see python3.12 install failure #118

Copy link
Collaborator

@twodrops twodrops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Sorry for the delay.

@twodrops twodrops merged commit 2fc0472 into main Apr 24, 2024
2 checks passed
@twodrops
Copy link
Collaborator

@aniketsalve22 Looks like we have an issue here. Perhaps due to the recent access right changes?

@aniketsalve22
Copy link
Collaborator Author

@aniketsalve22 Looks like we have an issue here. Perhaps due to the recent access right changes?

Yes. We will have to update the access rights for the token.

@winterz
Copy link

winterz commented Apr 29, 2024

hmm, this is merged yet I'm not seeing a fix when trying to install with python3.12.
is this because of the access rights problem?

@twodrops
Copy link
Collaborator

That's right. The python package creation did not go through. Sorry to keep you waiting.
@aniketsalve22 Can you please follow this up?

@twodrops
Copy link
Collaborator

@aniketsalve22 We are hit with this issue softprops/action-gh-release#236
Tried the solutions there. It has to do with the recent migration to github enterprise, but not sure how it is affecting this. I have added as secret a token with all needed permissions 🙄

@twodrops
Copy link
Collaborator

twodrops commented Apr 30, 2024

@winterz @aniketsalve22
doxysphinx 3.3.8 with python 3.12 support is out 🍾 🎆 🥳
Thanks for your patience.

Edit:
I celebrated a bit too early. The PyPi deployment failed. PyPi meanwhile changed its authentication mechanism. Too many changes around us in short span. I am on it!

@twodrops twodrops deleted the feature/python-update branch April 30, 2024 05:15
@twodrops
Copy link
Collaborator

@winterz @aniketsalve22
And now finally done!!
https://pypi.org/project/doxysphinx/

@winterz
Copy link

winterz commented Apr 30, 2024

yay it works here. thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants