Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Pruning #1215

Merged
merged 127 commits into from
Aug 23, 2022
Merged

Hybrid Pruning #1215

merged 127 commits into from
Aug 23, 2022

Conversation

varunagrawal
Copy link
Collaborator

Added pruning of the eliminated hybrid bayes net.

Copy link
Collaborator

@ProfFan ProfFan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the code here are reviewed in other PRs


/* ****************************************************************************/
// // Test approximate inference with an additional pruning step.
// TEST(DCGaussianElimination, Incremental_approximate) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still commented out, need to merge other before merging this

TestResult tr;
return TestRegistry::runAllTests(tr);
}
/* ************************************************************************* */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline

@varunagrawal varunagrawal merged commit 89cdf4f into hybrid/hybrid-factor-graph Aug 23, 2022
@varunagrawal varunagrawal deleted the hybrid/pruning branch August 23, 2022 03:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants