Skip to content

Commit

Permalink
WIP - Consolidating Admin and Team task managers
Browse files Browse the repository at this point in the history
  • Loading branch information
tlawrie committed Jul 10, 2023
1 parent 4cb66f7 commit 74ab729
Show file tree
Hide file tree
Showing 30 changed files with 7 additions and 10 deletions.
6 changes: 3 additions & 3 deletions src/Config/appConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export const AppPath: Record<AppPathKey, string> = {

//Manage
ManageTaskTemplates: `/:teamId/task-templates`,
ManageTaskTemplateDetail: `/:teamId/task-templates/:name/:version/detail`,
ManageTaskTemplateDetail: `/:teamId/task-templates/:name/:version`,
ManageTaskTemplateEditor: `/:teamId/task-templates/:name/:version/editor`,
ManageTeamTokens: "/:teamId/tokens",
ManageTeamProperties: `/:teamId/parameters`,
Expand All @@ -95,7 +95,7 @@ export const AppPath: Record<AppPathKey, string> = {
Settings: "/admin/settings",
TemplateWorkflows: "/admin/template-workflows",
TaskTemplates: "/admin/task-templates",
TaskTemplateDetail: `/admin/task-templates/:name/:version/detail`,
TaskTemplateDetail: `/admin/task-templates/:name/:version`,
TaskTemplateEditor: `/admin/task-templates/:name/:version/editor`,
TeamList: "/admin/teams",
Tokens: "/admin/tokens",
Expand Down Expand Up @@ -164,7 +164,7 @@ export const appLink = {
settings: () => "/admin/settings",
templateWorkflows: () => "/admin/template-workflows",
taskTemplates: () => "/admin/task-templates",
taskTemplateDetail: ({ name, version }: AdminTaskTemplateArgs) => `/admin/task-templates/${name}/${version}/detail`,
taskTemplateDetail: ({ name, version }: AdminTaskTemplateArgs) => `/admin/task-templates/${name}/${version}`,
taskTemplateEditor: ({ name, version }: AdminTaskTemplateArgs) => `/admin/task-templates/${name}/${version}/editor`,
teamList: () => "/admin/teams",
tokens: () => `/admin/tokens`,
Expand Down
4 changes: 2 additions & 2 deletions src/Features/App/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ const Teams = lazy(() => import("Features/Teams"));
const ManageTeam = lazy(() => import("Features/TeamDetailed"));
const TeamProperties = lazy(() => import("Features/TeamProperties"));
const TeamTokens = lazy(() => import("Features/TeamTokens"));
const TeamTasks = lazy(() => import("Features/TeamTasks"));
const AdminTasks = lazy(() => import("Features/TeamTasks/AdminTasks"));
const TeamTasks = lazy(() => import("Features/TaskManager/TeamTasks"));
const AdminTasks = lazy(() => import("Features/TaskManager/AdminTasks"));
// const TaskTemplatesContainer = lazy(() => import("Features/ManageTeamTasks"));
const Users = lazy(() => import("Features/Users"));
const Workflows = lazy(() => import("Features/Workflows"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import { AppPath, appLink, FeatureFlag } from "Config/appConfig";
import { serviceUrl } from "Config/servicesConfig";
import styles from "../TaskManager.module.scss";

const HELMUT_TITLE = "Global Task Manager";
const HELMUT_TITLE = "Task Manager";

function TaskTemplatesContainer() {
const match = useRouteMatch();
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
//@ts-nocheck
import React, { useState } from "react";
import cx from "classnames";
import queryString from "query-string";
import { useQuery } from "Hooks";
import { Helmet } from "react-helmet";
import { Formik } from "formik";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ export function TaskTemplateOverview({
const [isSaving, setIsSaving] = React.useState(false);
const cancelRequestRef = React.useRef();
const queryClient = useQueryClient();

const params = useParams();
const history = useHistory();

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ function TaskTemplatesContainer() {
const { activeTeam } = useAppContext();
const history = useHistory();
const match = useRouteMatch();
const queryClient = useQueryClient();
const editVerifiedTasksEnabled = useFeature(FeatureFlag.EditVerifiedTasksEnabled);
const getTaskTemplatesUrl = activeTeam
? serviceUrl.getTaskTemplates({
Expand Down Expand Up @@ -117,7 +116,7 @@ function TaskTemplatesContainer() {
getTaskTemplatesUrl={getTaskTemplatesUrl}
/>
</Route>
<Redirect to={appLink.manageTaskTemplates({ teamId: activeTeam?.id })} />
<Redirect to={appLink.manageTaskTemplates({ teamId: activeTeam.id })} />
</Switch>
</div>
);
Expand Down
File renamed without changes.
File renamed without changes.

0 comments on commit 74ab729

Please sign in to comment.