Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create header with logo and site icon #5

Open
5 of 8 tasks
bobbingwide opened this issue Apr 25, 2021 · 2 comments
Open
5 of 8 tasks

Create header with logo and site icon #5

bobbingwide opened this issue Apr 25, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Apr 25, 2021

@AndrewMLeonard suggested making the theme look like WordPress.org in terms of style.
He developed an SVG for the site logo and as a site icon.
Now I need to attempt to implement them in the header.

After a lot of fiddling with Global Styles we managed to get the header to look a bit like what it should look like.

  • A site title link
  • A search box
  • A primary menu
  • And a Get button
  • with a blackish background and greyish text

Suffice it to say it's a long way off.

Requirements

  • Use an SVG logo for the site logo - replacing the site title
  • Use a transparent PNG file for the favicon

Here's a screenshot for 'desktop' display.
image

  • The underlined site title needs to be replaced by the site logo
  • There's an unwanted white margin
  • The search box has a label above it
  • The search box background is white not black
  • The current menu item isn't highlighted in blue
  • There's no fancy blue arrow under the current menu item
  • The fonts are wrong
  • The blue "Get" button doesn't hide
@bobbingwide bobbingwide self-assigned this Apr 25, 2021
@bobbingwide bobbingwide changed the title Create logo and site icon for thisis Create header with logo and site icon Apr 25, 2021
@bobbingwide
Copy link
Owner Author

Here are screenshots when the window is sized down.

  • make.wordpress.org switches to a hamburger menu.
  • The header should also include the WordPress Multi Site title
  • And a submenu

Note: WordPress.org uses the p2theme

image

image

@bobbingwide
Copy link
Owner Author

The search box background is white not black
There's no fancy blue arrow under the current menu item
The blue "Get" button doesn't hide

Never mind, wordpress.org's header changed with WordPress 5.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant