Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for WordPress 5.0 and the new block editor #3

Closed
bobbingwide opened this issue Apr 4, 2018 · 1 comment
Closed

Support for WordPress 5.0 and the new block editor #3

bobbingwide opened this issue Apr 4, 2018 · 1 comment
Assignees

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Apr 4, 2018

To support use of the new block editor we need to change the registration of the oik_testimonials CPT.
Add

$post_type_args['show_in_rest'] = true;

The testimonial_type custom category also needs to be show_in_rest. oik-testimonials will need to be dependent upon oik v3.2.4 or higher.

@bobbingwide bobbingwide self-assigned this Apr 4, 2018
@bobbingwide
Copy link
Owner Author

bobbingwide commented Jul 14, 2019

When I enabled the oik-testimonials CPT for the block editor, with Gutenberg 6.1 I got a white screen of death.

index.js?ver=1562837440:1 Uncaught TypeError: Cannot read property 'displayName' of undefined
    at index.js?ver=1562837440:1
    at editor.js?ver=7.5.2:24
    at index.js?ver=1562837440:1
    at index.js?ver=1562837440:2
    at Array.map (<anonymous>)
    at ne (index.js?ver=1562837440:2)
    at index.js?ver=1562837440:14
    at Array.forEach (<anonymous>)
    at Sc (index.js?ver=1562837440:14)
    at Object.so (index.js?ver=1562837440:12)
(anonymous) @ index.js?ver=1562837440:1
(anonymous) @ editor.js?ver=7.5.2:24
(anonymous) @ index.js?ver=1562837440:1
(anonymous) @ index.js?ver=1562837440:2
ne @ index.js?ver=1562837440:2
(anonymous) @ index.js?ver=1562837440:14
Sc @ index.js?ver=1562837440:14
so @ index.js?ver=1562837440:12
(anonymous) @ post.php?post=814&action=edit:582

This is resolved by updating to Gutenberg 6.1.1 which has the following fix.
WordPress/gutenberg#16518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant