Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create single and archive pages for oik-plugins custom post type #14

Closed
17 of 18 tasks
bobbingwide opened this issue Nov 2, 2020 · 4 comments
Closed
17 of 18 tasks
Assignees
Labels
enhancement New feature or request

Comments

@bobbingwide
Copy link
Owner

bobbingwide commented Nov 2, 2020

In the genesis-a2z theme the following PHP templates are used for the oik-plugins CPT.

Single page - single-oik-plugins.php
Archive page - archive.php

Requirement

Create FSE templates for both of these.

  • single-oik-plugins.html
  • archive-oik-plugins.html

Single page template parts

image

  • Header
  • Breadcrumbs
  • Content

image

  • Information
  • Download
  • Search
  • Page footer
  • footer

In the screen captures Content and Page footer are only partially shown. Footer is not shown at all.

Archive page

image

  • Header
  • Letters selection
  • Breadcrumbs
  • Category description. Is this really necessary for the Letters category?
  • 3 column display of block title with link and featured image
  • Search
  • Page footer
  • footer

Note: The 3 column display is different from that already delivered in archive.html, which uses category-query.html.
Looks like archive.html should use a different template part to implement the 3 column main query.

@bobbingwide bobbingwide added the enhancement New feature or request label Nov 2, 2020
@bobbingwide bobbingwide self-assigned this Nov 2, 2020
@bobbingwide
Copy link
Owner Author

The top half of the single-oik-plugins.html page looks like this.
Note: I've not yet populated the color palette.

image

The bottom half looks like this:
image

Notes:

  • The information template part uses the oik-block/fields block.
  • The download template part uses the core/shortcode block with shortcode [oikp_download plugin=.]
  • The core/seach block used in the search template part has yet to be styled.
  • The footer area now consists of 3 template parts: page-footer, footer and footer-menu.

@bobbingwide
Copy link
Owner Author

The archive template uses the archive-query template part instead of the category-query template part used in category. The category-description template part is not included.
image

Now we need to check what happens if we select a custom taxonomy term or tag.

@bobbingwide
Copy link
Owner Author

bobbingwide commented Nov 3, 2020

Now we need to check what happens if we select a custom taxonomy term or tag.

It's OK for the letters taxonomy as we don't really need a description of the letter.
And we can probably get by without the term description for tags as well.

bobbingwide added a commit that referenced this issue Nov 4, 2020
…header and footer menus into separate template parts
@bobbingwide
Copy link
Owner Author

Category description. Is this really necessary for the Letters category?

Retesting with Gutenberg 12.3.0 and/or WordPress 5.9-RC1. It doesn't seem necessary to have a Tag description. Certainly not in the archive template. But it could be useful in a tag template.

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant