Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation since the blocks have the wrong field name in the editor #20

Open
bobbingwide opened this issue Dec 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@bobbingwide
Copy link
Owner

I don't know what caused it but in the block editor there's no field name selected in the block editor
even though the front end display works.

image

This is probably due to the fact that I changed to logic to use the field key rather than field name but forgot to update the examples.
See #16

<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field","data":{"acf-field-name":"password","_acf-field-name":"field_645f589a88304"},"mode":"edit"} /-->
<!-- wp:acf-field/acf-field {"name":"acf-field/acf-field","data":{"field_645f589a88304":"field_64aa874448e00"},"mode":"edit"} /-->
@bobbingwide bobbingwide added the bug Something isn't working label Dec 7, 2023
@bobbingwide bobbingwide self-assigned this Dec 7, 2023
@bobbingwide
Copy link
Owner Author

While updating the documentation on s.b/oikcom I was unable to get data for the Clone fields using seamless.
The call to get_field_object() wasn't returning any results for long key field_64ac359853cbf_field_64ac34578821f.
I needed to change it to second half of the key, ie the last 19 digits.

----+----1----+----
field_64ac34578821f

@bobbingwide
Copy link
Owner Author

I also needed to change the block's CSS file to cater for the new class names on the block.
eg change from acf-field-gallery to acf-type-gallery

I also needed some extra selectors to support styling when the Display label checkbox is set to true. See #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant