Parameter generation #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick check on the performance for the new filters using the sine sweep benchmark code from #75 . Here's the 0.2.2 performance for best and fast:
And for the updated 0.3.0 versions:
Colormaps are designed to be neutral hue at -96dB, anything colored blue is below that level. |
This was referenced Jul 26, 2023
plakal
added a commit
to tensorflow/models
that referenced
this pull request
Jul 26, 2023
Fixed vggish_smoke_test failures due to resampy changes. bmcfee/resampy#98 seems to have updated resampy's default filters in a way that made the VGGish smoke test's embedding outputs drift too far from the expected values. Fixed the test by not resampling in the critical path of generating an embedding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #96 by including a reproducible script to construct filters subject to specified constraints. (Note to self: this should seed the RNG.)
It also addresses #97 somewhat by updating our pre-computed filters.