Fix data panic #18
Open
Fix data panic #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
voldyman
approved these changes
Jul 6, 2022
| chunkI := uint32(docNum) / defaultDocumentChunkSize | ||
| storedFieldDecompressed := s.decompressedStoredFieldChunks[chunkI] | ||
| storedFieldDecompressed.m.Lock() | ||
| if storedFieldDecompressed.data == nil { |
There was a problem hiding this comment.
This section tries to reduce the amount of repeated work by doing it inside a locked section, have you considered performing the decompression outside the lock and then lock->check->update.
So we might end up with repeated work between multiple requests but less contention between them.
what do you thing? (and also @mschoch)
There was a problem hiding this comment.
@voldyman We don't want decompress all chunks, just want decompress the chunk which visited. so we decompress when visit, and to avoid decompress multiple, so we use lock to ensure just do once.
And about you talked i am not sure how to implement it, i think you can try to create a new PR or give some code for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is our version by many users using, for now no error found.