Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does upath2 really needs @types/node as peer dependency? #5

Closed
felipecrs opened this issue Mar 6, 2022 · 5 comments
Closed

Does upath2 really needs @types/node as peer dependency? #5

felipecrs opened this issue Mar 6, 2022 · 5 comments

Comments

@felipecrs
Copy link

felipecrs commented Mar 6, 2022 •
edited
Loading

This issues warnings on libraries depending on it, but which does not have @types/node added directly.

Example:

[3/4] Linking dependencies...
warning "rollup-plugin-typescript2 > @yarn-tool/resolve-package > upath2@3.1.12" has unmet peer dependency "@types/node@*".
@felipecrs felipecrs mentioned this issue Mar 6, 2022
Merged
@felipecrs
Copy link
Author

@bluelovers, any chance you can publish a new version with the fix? I don't want to rush anything, but maybe you forgot. :)

@bluelovers
Copy link
Owner

maybe is rollup typescript2 didn't update deps version

@felipecrs
Copy link
Author

But no newer versions of upath2 were released after 20b611f.

@bluelovers
Copy link
Owner

oops, should be ok now

@felipecrs
Copy link
Author

Thanks a lot! :)

felipecrs added a commit to felipecrs/rollup-plugin-typescript2 that referenced this issue May 11, 2022
@felipecrs
Update @yarn-tool/resolve-package from 1.0.40 to 1.0.47
d67418c 
In order to fix this issue:

bluelovers/ws-iconv#5
This was referenced May 11, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bluelovers @felipecrs