Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk/testing): support axe-core 4.7 #1494

Merged
merged 10 commits into from
Aug 18, 2023
Merged

feat(sdk/testing): support axe-core 4.7 #1494

merged 10 commits into from
Aug 18, 2023

Conversation

johnhwhite
Copy link
Member

@johnhwhite johnhwhite commented Jul 6, 2023 •
edited by azure-boards bot
Loading

@blackbaud-sky-build-user
Copy link
Collaborator

blackbaud-sky-build-user commented Jul 6, 2023 •
edited
Loading

Storybook preview

Component Storybooks:

Apps:

@nx-cloud
Copy link

nx-cloud bot commented Jul 6, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18720a2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 8 targets

Sent with 💌 from NxCloud.

@johnhwhite johnhwhite added the risk level (author): 3 This change has a moderate chance of introducing a bug label Jul 7, 2023
@johnhwhite johnhwhite marked this pull request as ready for review July 28, 2023 14:42
@Blackbaud-SteveBrush Blackbaud-SteveBrush changed the base branch from main to 8.x.x July 31, 2023 15:02
Blackbaud-SteveBrush
Blackbaud-SteveBrush reviewed Aug 3, 2023
View reviewed changes
libs/components/lookup/src/lib/modules/autocomplete/autocomplete.component.html Outdated Show resolved Hide resolved
libs/components/lookup/src/lib/modules/autocomplete/autocomplete.component.spec.ts Outdated Show resolved Hide resolved
libs/components/lookup/src/lib/modules/autocomplete/autocomplete.component.ts Show resolved Hide resolved
libs/components/lookup/src/lib/modules/autocomplete/autocomplete.component.ts Show resolved Hide resolved
libs/components/lookup/testing/src/autocomplete/autocomplete-input-harness.ts Show resolved Hide resolved
libs/components/lookup/src/lib/modules/autocomplete/autocomplete-input.directive.ts Outdated Show resolved Hide resolved
...id/src/lib/modules/ag-grid/cell-editors/cell-editor-lookup/cell-editor-lookup.component.html Show resolved Hide resolved
...id/src/lib/modules/ag-grid/cell-editors/cell-editor-lookup/cell-editor-lookup.component.html Outdated Show resolved Hide resolved
@Blackbaud-SteveBrush Blackbaud-SteveBrush self-assigned this Aug 11, 2023
@Blackbaud-SteveBrush Blackbaud-SteveBrush mentioned this pull request Aug 17, 2023
Merged
@johnhwhite johnhwhite added risk level (author): 2 This change has a slight chance of introducing a bug and removed risk level (author): 3 This change has a moderate chance of introducing a bug labels Aug 18, 2023
@Blackbaud-SteveBrush Blackbaud-SteveBrush added the risk level (reviewer): 3 This change has a moderate chance of introducing a bug label Aug 18, 2023
@johnhwhite johnhwhite enabled auto-merge (squash) August 18, 2023 16:10
@johnhwhite johnhwhite merged commit 1481956 into 8.x.x Aug 18, 2023
29 checks passed
@johnhwhite johnhwhite deleted the axe-4.7-support branch August 18, 2023 16:13
blackbaud-sky-build-user pushed a commit that referenced this pull request Aug 18, 2023
@johnhwhite @blackbaud-sky-build-user
feat(sdk/testing): support axe-core 4.7 (#1494)
e959656 
* feat(sdk/testing): support axe-core 4.7

* Fix lookup accessibility when using ariaLabel and not ariaLabelledBy

* Revert autocomplete, update isOpen logic, consolidate ag-grid lookup field ariaLabel

* Simplify changes

* Update property name

* Use `controlId` for aria-labelledby rather than creating a `<label>` element
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Aug 18, 2023
Merged
@blackbaud-sky-build-user
Copy link
Collaborator

Cherry-pick successful! 🍒 🎉 See #1607

@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Aug 18, 2023
Merged
johnhwhite added a commit that referenced this pull request Aug 18, 2023
@blackbaud-sky-build-user @johnhwhite
feat(sdk/testing): support axe-core 4.7 (#1494) (#1607)
0a82e99 
* feat(sdk/testing): support axe-core 4.7

* Fix lookup accessibility when using ariaLabel and not ariaLabelledBy

* Revert autocomplete, update isOpen logic, consolidate ag-grid lookup field ariaLabel

* Simplify changes

* Update property name

* Use `controlId` for aria-labelledby rather than creating a `<label>` element

Co-authored-by: John White <750350+johnhwhite@users.noreply.github.com>
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Aug 18, 2023
Merged
@johnhwhite johnhwhite added the introduced a bug This change was later found to have created a bug label Aug 29, 2023
@johnhwhite johnhwhite mentioned this pull request Aug 29, 2023
Merged
@blackbaud-sky-build-user blackbaud-sky-build-user mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Blackbaud-SteveBrush Blackbaud-SteveBrush Blackbaud-SteveBrush approved these changes

Assignees

@Blackbaud-SteveBrush Blackbaud-SteveBrush

Labels
introduced a bug This change was later found to have created a bug risk level (author): 2 This change has a slight chance of introducing a bug risk level (reviewer): 3 This change has a moderate chance of introducing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnhwhite @blackbaud-sky-build-user @Blackbaud-SteveBrush