[PM-12242] Updated default US and EU region URLs #939
Merged
+179
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ix approach but a fixed set of URLs. Also fixed share Send url for US region.
fedemkr
changed the title
fedemkr
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #939 +/- ##
=======================================
Coverage 88.66% 88.67%
=======================================
Files 622 622
Lines 39309 39322 +13
=======================================
+ Hits 34855 34868 +13
Misses 4454 4454 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
holow29
reviewed
Sep 17, 2024
BitwardenShared/Core/Platform/Models/Domain/EnvironmentUrlDataTests.swift
Outdated
Show resolved
Hide resolved
…Tests.swift Co-authored-by: holow29 <67209066+holow29@users.noreply.github.com>
BitwardenShared/Core/Platform/Models/Domain/EnvironmentUrlData.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-12242
📔 Objective
Update default US and EU region URLs to not use append suffix logic as in Self-host but fixed set URLs.
Check MAUI code as reference.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes