fix some warnings #225
Merged
fix some warnings #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitshifter
requested changes
Aug 10, 2021
|
Are these clippy warnings? It would be good to clarify, I haven't noticed them. |
|
¨¨<'_>`` these are from rust_2018_idioms. Hidden anonymous lifetime are deprecated and wil be remove in rust 2021. the others are from clippy. |
bitshifter
reviewed
Aug 10, 2021
Ah right, it's a bit confusing because |
|
It's enabling them but it is in rustc. those of clippy always begin with |
bitshifter
reviewed
Aug 10, 2021
bitshifter
reviewed
Aug 10, 2021
bitshifter
approved these changes
Aug 10, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.