Update text for unknown operations in proposals #3663
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
PR for #3661.
Show the text "Unknown operation" with the operation type number for operations which are not yet implemented in UI. For those operations, link to the internal block explorer is removed because it is either broken (on the proposal details page) or redundant (on the account activities page).
Translation was done with Google Translate.
See https://pr.bts.mobi/#/account/blockchain-prize for result of changes.
This is the first step in fixing issues like #3661. Since it is a catch-all solution, it could reduce similar scam issues in the future. I think it's urgent and we need to release a new version containing it ASAP. To be clear, I know we want to support showing all operation types in proposals, and we can do it step by step.
General
Please make sure the following is done:Code Preparation
Please review all your changes one last time before committing
Testing
The branch has been tested on the following browsers (desktop and mobile view)
Please provide screenshots/licecap of your changes below
![image](https://private-user-images.githubusercontent.com/9946777/265279519-45fea74e-fb75-427f-ab27-3d705f1533ee.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMDE3NjMsIm5iZiI6MTcyNDMwMTQ2MywicGF0aCI6Ii85OTQ2Nzc3LzI2NTI3OTUxOS00NWZlYTc0ZS1mYjc1LTQyN2YtYWIyNy0zZDcwNWYxNTMzZWUucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDQzNzQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YTNmZWU2ZTFjZDQzY2YyNjdhMWNmMDM4MDAzYTZiYjY0YjUzNWJkZGM0NmJhZjhhZWI5NzJiMmU0YjkxY2Q1MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.RF9f4A7RsFR9f2SIiLxFwNATnd8pawCxLbiPoD7kDX0)
![image](https://private-user-images.githubusercontent.com/9946777/265279543-b00637a5-af94-4750-974c-772552b9d5f0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMDE3NjMsIm5iZiI6MTcyNDMwMTQ2MywicGF0aCI6Ii85OTQ2Nzc3LzI2NTI3OTU0My1iMDA2MzdhNS1hZjk0LTQ3NTAtOTc0Yy03NzI1NTJiOWQ1ZjAucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDQzNzQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Y2Y3ZjRlNjlkZGY3ZWUxYjNjMzFkNzk5NzJkNDFhODUzYzhjZmVmZDQxMGE3N2M1MjBiOGViYjMzZDAzOGMyZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.2njYU3jMnDzb8gLmda-xAxSsSdmASz2kuPSFW6EFeJo)
In German:
![image](https://private-user-images.githubusercontent.com/9946777/265279592-c17d62d3-5b75-4595-9dda-4194406cb326.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMDE3NjMsIm5iZiI6MTcyNDMwMTQ2MywicGF0aCI6Ii85OTQ2Nzc3LzI2NTI3OTU5Mi1jMTdkNjJkMy01Yjc1LTQ1OTUtOWRkYS00MTk0NDA2Y2IzMjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyMiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjJUMDQzNzQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NmYwNmVkOTBlYjMyN2RmOWRkNTk4M2JhZjhlNDliODk5ODZjNDcxOTAwNzg0NTViMzMxZWNiNzFkNWNmYTUxNSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.D1uxWy6aiMneL659y_LLgcpjVk2d44oK4G_g_ecdMH0)