Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separators for account update ops in proposals #3467

Merged
merged 2 commits into from
Mar 13, 2022

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Mar 12, 2022

General

Please check the screenshots below.

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

Without the change (mainnet):
image

With the change (mainnet):
image

Without the change (testnet):
image

With the change (testnet):
image

@abitmore abitmore force-pushed the proposal-account-update-separators branch from be3abb6 to 8d631cb Compare March 12, 2022 23:19
@sschiessl-bcp sschiessl-bcp merged commit c5a0a8d into develop Mar 13, 2022
@sschiessl-bcp sschiessl-bcp deleted the proposal-account-update-separators branch March 13, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.220214 Release
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants