Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken image in private key viewer #3438 #3445

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Fix broken image in private key viewer #3438 #3445

merged 1 commit into from
Jan 21, 2022

Conversation

xiangxn
Copy link
Contributor

@xiangxn xiangxn commented Jan 20, 2022

Fix broken image in private key viewer.

Closes #3438

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 21, 2022

@sschiessl-bcp
Bitsharesjs may need to release a version. Currently, installing the Github source directly will cause the AppVeyor build to fail.

@xiangxn
Copy link
Contributor Author

xiangxn commented Jan 21, 2022

This problem was caused by the mkdirp command in bitsharesjs, which I have dealt with.
Can be safely merged

@sschiessl-bcp sschiessl-bcp merged commit 39b2889 into bitshares:develop Jan 21, 2022
@xiangxn xiangxn deleted the fix-img-import branch March 1, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
5.0.220214 Release
Awaiting triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken image in private key viewer (develop branch)
2 participants
@xiangxn @sschiessl-bcp