-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade travis and appveyor to github action #3416
upgrade travis and appveyor to github action #3416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
How about other assets (e.g. the HTML zip)?
body: ${{ steps.create_body.outputs.body }} | ||
draft: true | ||
- name: Upload dmg | ||
uses: actions/upload-release-asset@v1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This action (https://github.com/actions/upload-release-asset) is unmaintained too.
Note: to use this workflow, we need to label pull requests with "feature", "bug" or "bugfix" so that they'll be included in the release notes. |
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: echo "PackageVersion=$(cat package.json | sed 's/,/\n/g' | grep '\"version\":' | sed 's/:/\n/g' | sed '1d' | sed 's/ //g' | sed 's/\"//g' | sed 's/}//g')" >> $GITHUB_ENV |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, these long lines look ugly when viewing Github.com in a web browser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be optimized here, such as using jq, but I don't want to use too many external programs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commands can be simply wrapped with the \
sign and etc. Actually, since you have (
in the command, it supports multiple lines by itself already. E.G.
- run: |
echo "PackageVersion=$(cat package.json | sed 's/,/\n/g' | grep '\"version\":' |
sed 's/:/\n/g' | sed '1d' | sed 's/ //g' | sed 's/\"//g' | sed 's/}//g')" \
>> $GITHUB_ENV
Just my 2 cents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is not the only long line in the pull request. It's best to wrap them all.
We need to generate and upload binary files, and include the hash of the file. The new maintenance version is not used because GITHUB_TOKEN is used in it, for the best to use only the github/actions version |
These marks are the most basic, we can add new ones, and we can add them according to the manager's ideas. |
Note: this PR has lower priority than #3413. Please finish that one first. Try not to be distracted. |
@abitmore @sschiessl-bcp |
Thanks. |
will test with next release |
Update current travis and appveyor to GitHub actions
About the modification of #3414 and #3302 This action will automatically generate the following effects when triggered: