Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy deposit modal cache upon closing it #3388

Merged
merged 1 commit into from
Jan 31, 2022

Conversation

AmmarYousefM
Copy link
Contributor

In case platform user owns multiple users and wants to deposit to thus different users; they will need to clear the browser cache every time they want to use different user for deposit modal API data.

In case platform user owns multiple users and wants to deposit to thus different users; they will need to clear the browser cache every time they want to use different user for deposit modal API data.
@sschiessl-bcp
Copy link
Contributor

destroyOnClose clears browser cache?

@AmmarYousefM
Copy link
Contributor Author

destroyOnClose clears browser cache?

It clears only the modal’s cache hence the only way to clear modal’s cache in case you want to switch user is to clear browser’s cache.

@sschiessl-bcp
Copy link
Contributor

If I don't switch user I still need to fetch the address every time now, don't I? Maybe the modal should check if the username changed?

@ioBanker
Copy link
Member

ioBanker commented Nov 21, 2021

This will cause that every time you open the deposit modal to pick up the asset you want to choose deposit again; I don't see a reasoning behind keeping old records in modal after closing it, if you have please address.

@sschiessl-bcp sschiessl-bcp merged commit 3b128b3 into bitshares:develop Jan 31, 2022
@sschiessl-bcp
Copy link
Contributor

Let's try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.220214 Release
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

3 participants