Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3264, get rid of warnings #3380

Merged
merged 7 commits into from
Jul 16, 2021
Merged

Fix #3264, get rid of warnings #3380

merged 7 commits into from
Jul 16, 2021

Conversation

freak5g
Copy link
Contributor

@freak5g freak5g commented Jul 15, 2021

issue 1:
Screenshot from 2021-07-12 22-23-39

issue 2:

Warning: Use the defaultValue or value props instead of setting children on <textarea>.
in textarea (created by CreateAccountPassword)

@freak5g freak5g changed the title Fixed minor issues Fix #3264, get rid of warnings Jul 16, 2021
@sschiessl-bcp
Copy link
Contributor

Generally, dangerouslySetInnerHTML is, well, dangerous. But since the input is controlled this is acceptable.

@sschiessl-bcp sschiessl-bcp merged commit 6a437a1 into bitshares:develop Jul 16, 2021
@freak5g
Copy link
Contributor Author

freak5g commented Jul 16, 2021

I could split corresponding translation into three parts and format message in render function which works fine; or just remove any formatting at all and keep it simple. I've chosen dangerous approach encouraged by the law of precedent.

@freak5g freak5g deleted the patch-1 branch July 16, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants