Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording about writing down name and pass #3373

Merged
merged 6 commits into from
Jul 16, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented May 24, 2021

General

After an account in cloud wallet mode is created, prompt the user to write down not only the password, but also the account name.

Translations:

  • en and zh: done
  • fr and co: the old text was not translated, so overwritten with new text
  • other languages: don't know how to handle them

General

Please make sure the following is done:

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

User interface changes

Delete this section if there weren't any UI changes. Please make sure you tested your changes in all themes

  • Dark
  • Light
  • Midnight

Please provide screenshots/licecap of your changes below

@abitmore abitmore marked this pull request as ready for review May 24, 2021 15:57
@sschiessl-bcp sschiessl-bcp merged commit 8e57084 into develop Jul 16, 2021
@sschiessl-bcp sschiessl-bcp deleted the abitmore-patch-4 branch July 16, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
5.0.220214 Release
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants