Hide own accounts from to field in send modal #3344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General
Workaround for #3343Add a new property
includeMyActiveAccounts
to Account Selector, enabled by default, disabled in Send Modal.BTW updated some checks so that checking for scammers has higher priority.
General
Please make sure the following is done:Code Preparation
Please review all your changes one last time before committing
Testing
The branch has been tested on the following browsers (desktop and mobile view)
Please provide screenshots/licecap of your changes below
The screenshot below was for reproducing a scenario that assumes
abit-test
is the attacker,abit-test2
is the victim, andabit
is in contacts.Without this patch:
![image](https://user-images.githubusercontent.com/9946777/109127780-16964280-774f-11eb-9e34-23f4b2695662.png)
With the patch, it won't show my accounts at all, which is a bit inconvenient but safer (a test environment is temporarily available at https://pr.bts.mobi/):