Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build-hash instead of build in Github Actions #3338

Merged
merged 2 commits into from
Jul 27, 2021

Conversation

abitmore
Copy link
Member

@abitmore abitmore commented Feb 18, 2021

Fixes the deposit-withdraw page missing issue when doing auto-deployment via Github Actions (#3302 (comment)).

Related code:

bitshares-ui/build.sh

Lines 14 to 18 in df6d96e

## Build the hash wallet if wer're on Linux
if [ "$unamestr" == 'Linux' ]
then
npm run build-hash
fi

"build": "cross-env NODE_ENV=production webpack --env.prod",
"build-nougly": "cross-env NODE_ENV=production webpack --env.prod --env.noUgly",
"build-hash": "cross-env NODE_ENV=production webpack --env.prod --env.hash --env.baseUrl=''",

/* Workaround in which the github pages server will find a file when it looks
for /deposit-withdraw that will redirect to the hash router's equivalent
/#/deposit-withdraw */
if (env.hash)
plugins.push(
new CopyWebpackPlugin(
[
{
from: path.join(
root_dir,
"app",
"components",
"DepositWithdraw",
"blocktrades",
"index.html"
),
to: path.join(
outputPath,
"deposit-withdraw",
"index.html"
),
toType: "file"
}
],
{}
)
);

to fix the deposit-withdraw page missing issue (#3302 (comment))
@abitmore
Copy link
Member Author

Update: it seems this breaks the Github Actions auto-deployment workflow. Checking.

@abitmore
Copy link
Member Author

Fixed.

@sschiessl-bcp sschiessl-bcp merged commit d6dfce4 into develop Jul 27, 2021
@sschiessl-bcp sschiessl-bcp deleted the abitmore-patch-1 branch July 27, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants