Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- add RUDEX.PZM, icon and markets #3244

Merged
merged 1 commit into from
May 3, 2020

Conversation

siralexpu
Copy link
Contributor

  • add RUDEX.PZM, icon and markets
  • add custom field for public key PZM (for withdrawals)
  • change endpoint RuDEX gateApi

@sschiessl-bcp
Copy link
Contributor

Could you elaborate please on the need for the public key field plz for withdrawals?

The old endpoint for gateway is still live?

@siralexpu
Copy link
Contributor Author

Could you elaborate please on the need for the public key field plz for withdrawals?

The old endpoint for gateway is still live?

Yes - all endpoints are currently supported and operational ..

The public key is needed for output. This is a feature of the blockchain.

The public key is NOT ALWAYS known and can be obtained from the PRIZM blockchain - these are features.
While the account is not activated in the blockchain, information about its public key cannot be obtained, because not available - in this case - the user needs to enter it on his own - the user can find it in his wallet. After activating the account, the public key becomes available for receipt and auto-completion in the corresponding field in DEX UI.

@sschiessl-bcp
Copy link
Contributor

Your PR includes a change to the generic WithdrawModal. Would you be able to do do integration tests for all gateways with release candidate?

@siralexpu
Copy link
Contributor Author

Your PR includes a change to the generic WithdrawModal. Would you be able to do do integration tests for all gateways with release candidate?

yes, I can check

@sschiessl-bcp
Copy link
Contributor

Please rebase onto latest develop

- add custom field for public key PZM (for withdrawals)
- change endpoint RuDEX gateApi
@sschiessl-bcp sschiessl-bcp merged commit b20aad2 into bitshares:develop May 3, 2020
@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.20210216 Release via automation May 3, 2020
@sschiessl-bcp sschiessl-bcp moved this from In progress to Done in 5.0.20210216 Release May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants