Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bridge withdrawals based on mapping data #3235

Merged

Conversation

motrebski
Copy link
Contributor

@motrebski motrebski commented Mar 27, 2020

General

Blocktrades bridge has functionality in wich users can do withdrawals. Memo information is now based on data which are getting from new mapping API call.

Code Preparation

Please review all your changes one last time before committing

  • Check for unused code
  • No unrelated changes are included
  • None of the changed files are reformatting only
  • Code is self explanatory or documented
  • All written text is properly translated (english language)

Testing

The branch has been tested on the following browsers (desktop and mobile view)

  • Chrome
  • Opera
  • Firefox
  • Safari

There were not changes in UI.

@sschiessl-bcp
Copy link
Contributor

Is the current implementation still working?

What is the purpose of the new mapping data?

@dnotestein
Copy link
Contributor

For the bitshares bridge, we use to use a memo system like "btc:my_receive_address". Now the memo is a UUID. I forget all the reasons for the change, but it's something we want.

@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.20210216 Release via automation Apr 27, 2020
@sschiessl-bcp sschiessl-bcp merged commit a48264f into bitshares:develop Apr 27, 2020
5.0.20210216 Release automation moved this from In progress to Done Apr 27, 2020
@sschiessl-bcp
Copy link
Contributor

Merged, only affects Blocktrades.

If you want or can, I would be interested in hearing the reasons behind the change @dnotestein

@sschiessl-bcp
Copy link
Contributor

The release candidate is out, could you please test your integration? #3251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants