Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default find-market search instead of OPEN #3198

Merged
merged 2 commits into from
Apr 27, 2020

Conversation

litepresence
Copy link
Contributor

This would eliminate the behavior of reference UI pointing at defunct OPEN markets and make the default behavior gateway UIA and smartcoin MPA agnostic by pointing towards all Bitcoin markets.

I also suggest it be implemented in conjunction with:

Use BTS as find market basic pair by froooze · Pull Request #3191

So that then BTS is the default primary search token and all Bitcoin markets which pair to BTS are shown by default.

This would eliminate behavior of pointing at defunct OPEN markets and make the default behavior gateway uia and mpa agnostic
@sschiessl-bcp
Copy link
Contributor

How about not loading anything per default unless user types the quote asset?

@litepresence
Copy link
Contributor Author

How about not loading anything per default unless user types the quote asset?

This would also be satisfactory.

I'm of the opinion that BTC would create more user interest by pulling up all the major UIA'a and MPA's which offer bitcoin. In essence it gives every subproject with a BTC offering (the most common) a slice of advertising space ranked by volume. Keeping with BTC would result in a list of the most noteworthy projects on the DEX:

bitBTC
gdexBTC
rudexBTC
xbtsxBTC
deexBTC
openBTC
bridgeBTC

Something I don't understand... even if BTC is placed as the search criteria, the HONEST project I'm working on does not come up unless you specifically search for it. Why is this?

Screenshot from 2020-02-26 08-51-24
Screenshot from 2020-02-26 08-49-50

@sschiessl-bcp
Copy link
Contributor

After having searched for "HONEST" once then typing "BTC" shows it. Must be an issue in the lazy asset loading

image

@sschiessl-bcp
Copy link
Contributor

Looking at the list of responses for BTC I am not sure if that is better than nothing :)

@litepresence
Copy link
Contributor Author

After having searched for "HONEST" once then typing "BTC" shows it. Must be an issue in the lazy asset loading

correct.

if you open the UI and type BTC, then HONEST.BTC does NOT appear

but if you search once for HONEST
...and then subsequently search for BTC
on the second search HONEST.BTC does appear.

Which is less than helpful in terms of making users aware of nascent markets; the lay user must already know about the nascent market - even if it has more volume than incumbent markets - before the UI informs them of it. Seems counter productive.

@litepresence
Copy link
Contributor Author

litepresence commented Feb 26, 2020

Looking at the list of responses for BTC I am not sure if that is better than nothing :)

I could be so compelled. I agree with your initial response that, if not BTC, then as a baseline, "nothing" would be better than OPEN.

@froooze
Copy link
Collaborator

froooze commented Feb 28, 2020

Looking at the list of responses for BTC I am not sure if that is better than nothing :)

I think no search input is the best

@sschiessl-bcp sschiessl-bcp added this to In progress in 5.0.20210216 Release via automation Apr 27, 2020
@sschiessl-bcp sschiessl-bcp merged commit 53cdc34 into bitshares:staging Apr 27, 2020
5.0.20210216 Release automation moved this from In progress to Done Apr 27, 2020
@sschiessl-bcp sschiessl-bcp changed the title Use BTC as default find-market search instead of OPEN Disable default find-market search instead of OPEN Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants