-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order cancellation fee error #3486
Comments
"bug looks very random, had to cancel a lot of orders, before the fee asset switched" |
Reproducable? |
"When i want to cancel 1 order,it's not working,no chance of canceling.But when i select 2 orders to get canceled in the same time,then it works good." |
It seems to happen on the market page. |
https://github.com/bitshares/bitshares-ui/blob/develop/app/actions/MarketsActions.js#L726 https://github.com/bitshares/bitshares-ui/blob/develop/app/lib/common/account_utils.js#L92 This doesn't seem to be a bug, according to the logic of the current code, the cancellation fee is not defaulted to BTS |
The default cancellation fee asset should be the one configured in settings by the user, which is not always BTS. If the account has no sufficient balance of that asset to pay the fee, or the fee pool of that asset is not usable, then use the fallback logic. |
I have dealt with this issue, if you have time you can review and merge. |
* fix 3486 * introduce raiseIfInsufficient to reduce duplicate code * default to given preference if nothing else has balance * forgot to adjust myopenorders catch * fix subscript overflow * fix 3486 Co-authored-by: Stefan <toleantech@gmail.com>
Reopening for review. |
I think the patch #3492 might work in most cases, the most useful part is the logic "can't pay fee, show user his chosen default". But it is not perfect.
That said, I'm fine to keep the status quo by now. @sschiessl-bcp what do you think? |
The fix helps in a case where the user sees that he is able to pay the fee, but actually can't, because it's too many orders. |
Describe the bug
Why the fee to be paid is coming up in "bullion" and not BTS?
To Reproduce
Steps to reproduce the behavior:
"Just cancelling my orders and re-doing them because their about to expire, It's not doing it to all of them but more than just 1"
Expected behavior
Fee in BTS.
Screenshots
![image](https://user-images.githubusercontent.com/9946777/161428576-7309079c-21ed-4647-8861-8d72bdf07ea4.png)
Desktop (please complete the following information):
Smartphone (please complete the following information):
Additional context
"bug looks very random, had to cancel a lot of orders, before the fee asset switched"
The text was updated successfully, but these errors were encountered: