Order cancellation fee error

[abitmore]

Describe the bug

Why the fee to be paid is coming up in "bullion" and not BTS?

To Reproduce
Steps to reproduce the behavior:
"Just cancelling my orders and re-doing them because their about to expire, It's not doing it to all of them but more than just 1"

Expected behavior
Fee in BTS.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
"bug looks very random, had to cancel a lot of orders, before the fee asset switched"

[abitmore]

"bug looks very random, had to cancel a lot of orders, before the fee asset switched"

[sschiessl-bcp]

Reproducable?

[xiangxn]

I have not been able to reproduce the issue either, it may be related to the data of a single account.

For example: when there is no BTS in the account, the fee is other assets.

[abitmore]

"When i want to cancel 1 order,it's not working,no chance of canceling.But when i select 2 orders to get canceled in the same time,then it works good."

[abitmore]

It seems to happen on the market page.

[xiangxn]

see:
https://github.com/bitshares/bitshares-ui/blob/develop/app/components/Exchange/MyOpenOrders.jsx#L218

https://github.com/bitshares/bitshares-ui/blob/develop/app/actions/MarketsActions.js#L726

https://github.com/bitshares/bitshares-ui/blob/develop/app/lib/common/account_utils.js#L92

This doesn't seem to be a bug, according to the logic of the current code, the cancellation fee is not defaulted to BTS

[abitmore]

The default cancellation fee asset should be the one configured in settings by the user, which is not always BTS. If the account has no sufficient balance of that asset to pay the fee, or the fee pool of that asset is not usable, then use the fallback logic.

[xiangxn]

I have dealt with this issue, if you have time you can review and merge.
@sschiessl-bcp @abitmore

[abitmore]

Reopening for review.

[abitmore]

I think the patch #3492 might work in most cases, the most useful part is the logic "can't pay fee, show user his chosen default".

But it is not perfect.

• It checks the fee pools each time, rather than cumulatively.
• The additional (accumulative) balance check has no fallback logic but only throws an exception. This code actually helps nothing, because the user may know that the balance is insufficient too even without the code.

That said, I'm fine to keep the status quo by now. @sschiessl-bcp what do you think?

[sschiessl-bcp]

The fix helps in a case where the user sees that he is able to pay the fee, but actually can't, because it's too many orders.