Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The margin call price in UI is wrong #3286

Closed
shulthz opened this issue Sep 12, 2020 · 1 comment · Fixed by #3507
Closed

The margin call price in UI is wrong #3286

shulthz opened this issue Sep 12, 2020 · 1 comment · Fixed by #3507
Assignees
@xiangxn
Projects
5.0.220701 Release

Comments

@shulthz
Copy link
Contributor

shulthz commented Sep 12, 2020

As BSIP74

The margin call price should be
margin_call_order_price = median_feed_price / (MSSR - MCFR)

shouldn't be
margin_call_order_price = median_feed_price / MSSR

https://github.com/bitshares/bsips/blob/master/bsip-0074.md
@abitmore abitmore added this to To do in 5.0.220701 Release via automation Apr 24, 2022
@abitmore
Copy link
Member

@xiangxn

@xiangxn xiangxn mentioned this issue Apr 26, 2022
Merged
5.0.220701 Release automation moved this from To do to Done Apr 26, 2022
xiangxn added a commit that referenced this issue Apr 26, 2022
@xiangxn
Merge pull request #3507 from xiangxn/fix-3286
72a272b 
Fix the margin call price in UI is wrong #3286
xiangxn added a commit that referenced this issue Apr 26, 2022
@xiangxn
Revert "Fix the margin call price in UI is wrong #3286"
e4f342e
@abitmore abitmore mentioned this issue Apr 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiangxn xiangxn

Labels
None yet
Projects
No open projects
5.0.220701 Release
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the margin call price in UI is wrong #3286 xiangxn/bitshares-ui
3 participants
@xiangxn @abitmore @shulthz