Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0] Wrong value in Portfolio #3071

Closed
abitmore opened this issue Sep 24, 2019 · 4 comments
Closed

[0] Wrong value in Portfolio #3071

abitmore opened this issue Sep 24, 2019 · 4 comments
Assignees
@sschiessl-bcp
Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [6] RC Blockage Impact flag identifying UI Release Candidate blockage
Milestone
191217

Comments

@abitmore
Copy link
Member

Describe the bug
Data in the value column is wrong.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'https://develop.bitshares.org/#/account/gamma-rabbit'

Expected behavior

  1. The data should be sum of numbers, but not strings joined.
  2. When sorting, if the triangle icon ^ is in blue, the smallest number should be on the top.

Screenshots
image

Desktop (please complete the following information):

  • OS: Ubuntu 18.04
  • Browser Firefox
  • Version 65
@abitmore abitmore mentioned this issue Sep 24, 2019
Merged
@sschiessl-bcp
Copy link
Contributor

sschiessl-bcp commented Sep 27, 2019 •
edited
Loading

Was missing .. #3079

I will be checking your issue again now

sschiessl-bcp pushed a commit that referenced this issue Sep 27, 2019
fix for #3071
38d89dd 
Signed-off-by: Stefan Schiessl <stefan.schiessl@blockchainprojectsbv.com>
@sschiessl-bcp sschiessl-bcp added the [3] Bug Classification indicating the existing implementation does not match the intention of the design label Sep 27, 2019
@sschiessl-bcp sschiessl-bcp added this to the 190927 milestone Sep 27, 2019
@abitmore
Copy link
Member Author

abitmore commented Sep 27, 2019 •
edited
Loading

Now the string joining issue is fixed. But the data is still wrong, because there can be multiple debt positions in an account, but current code only takes one. BTW data in "in orders" seems correct. See https://develop.bitshares.org/#/account/abc.btsbots

image

image

P.S. I think the total value at the down-bottom corner should not be in the TCR column.

@sschiessl-bcp sschiessl-bcp added the [6] RC Blockage Impact flag identifying UI Release Candidate blockage label Nov 4, 2019
@sschiessl-bcp sschiessl-bcp modified the milestones: 191104, 191130 Nov 4, 2019
@sschiessl-bcp sschiessl-bcp reopened this Nov 8, 2019
@sschiessl-bcp sschiessl-bcp self-assigned this Nov 8, 2019
@sschiessl-bcp sschiessl-bcp changed the title Wrong value in Portfolio [0] Wrong value in Portfolio Nov 8, 2019
@sschiessl-bcp
Copy link
Contributor

@abitmore done

@abitmore
Copy link
Member Author

abitmore commented Nov 8, 2019

@sschiessl-bcp thanks. Verified.

@abitmore abitmore closed this as completed Nov 8, 2019
@sschiessl-bcp sschiessl-bcp mentioned this issue Nov 11, 2019
Closed
@sschiessl-bcp sschiessl-bcp modified the milestones: 191130, 191104 Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sschiessl-bcp sschiessl-bcp

Labels
[3] Bug Classification indicating the existing implementation does not match the intention of the design [6] RC Blockage Impact flag identifying UI Release Candidate blockage
Projects
None yet
Milestone
191217
Development

No branches or pull requests
2 participants
@abitmore @sschiessl-bcp