-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2] Add raw json for operations and objects #2657
Comments
Good idea, it shouldn't be difficult to view and verify the json transaction, which is just what the blockchain is all about.
|
@startailcoon Could you please clarify the following: What info should be in the raw json? this object or trx object or smth else? |
@OpenLedgerApp Exactly the spot. It's mainly to make it possible to view under the "Explorer -> View Block" section rather than when you make a new TX, which you probably know what it does. The Raw TX should view the JSON object for the TX in question, just like when we don't have a pretty view for an operation. You can view how we do on that when we have no match for a "TX Translation". I imagine it something like this, to make it visible but non intrusive. Much like your example above. |
@startailcoon ok, thanks for clarifying. Can i claim this one? |
@OpenLedgerApp it's already assigned to you, so feel free to work and push a PR on it. |
# Conflicts: # app/assets/stylesheets/layout/_page_layout.scss
@sschiessl-bcp see comments in #3001 (comment). |
@sschiessl-bcp by the way the modal in #2996 is NOT what I want. I need a JSON, not a tree. |
If you must have a tree in the module, please make a button to "expand all". |
Let's do copyable text in #3020. I consider this issue completed with the tree that allows inspection. Sorry if we misunderstood the intent of your request. |
It's clearly stated in OP, this issue is for adding "raw json". Unless you don't know what is a raw json. |
A well formatted JSON is much better than the appearance currently showing in UI. |
For the times I used this popup the "tree json" was sufficient for me and I didn't think more about it. You want plaintext. I put a question for you in the follow up issue. |
Please redo this issue. Current implementation is not acceptable.
Last but not least, I don't think it's a good practice to auto-close issues without the issue-creators' confirmation. I'm able to reopen issues that closed by developers because I'm an admin, but other normal users can not, it's super annoying, because nobody pays attention to closed issues, if they reply in the issue their messages would easily get lost, in in that case they have to create new issues. |
I can agree to that when the issue creator is a known to be active. |
@syalon recommended that we can add a QR code for the JSON so that it can be signed and broadcast via a mobile app. @sschiessl-bcp @xiangxn what do you think? (Also see #3020) |
Idea is to be able to click to the "confirm transaction" popup without unlocking and then be able to switch to a QR code? |
I'm not sure if I got what your said. Probably the most wanted behavior is to be able to construct transactions (be able to "claim" or "act as" an account) without login in the first place at all, but this looks like a big change (see also: #1285). The first and (I guess) easier step is to add a link/button to show a QR code (and as mentioned in #3020, a JSON string) on the existing transaction confirmation popup. |
I'm guessing this is to create a transaction in the browser and sign it with the app and broadcast it. Simple transfer transactions are feasible with QR codes, but some transaction data is very large and may not be suitable for QR codes. |
Yes it is a valid argument. I think a simple solution is to show an error if the data is too big to fit in a QR code.
References:
In addition, I think we need to encode the data in UTF-8? E.G. an |
If it can't support all transactions, then this feature is not very meaningful. |
Most of common transactions can be done with this, so I think it is worth doing. |
So, is the QR code for the entire transaction required here, or just the OP's QR code? |
The transaction. |
Is your feature request related to a problem? Please describe.
![image](https://user-images.githubusercontent.com/9946777/57178570-d297c680-6e72-11e9-84be-4a4e6bda1379.png)
In some cases it's not clear what the ops means.
Pages that I thought of:
Describe the solution you'd like
Add a link so the nerds can check the raw json (plain text, best formatted well), contains elements described in #2657 (comment)
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: