Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1][Style-Guide] Tooltip Layout #2293

Closed
startailcoon opened this issue Dec 9, 2018 · 10 comments · Fixed by #2680
Closed

[1][Style-Guide] Tooltip Layout #2293

startailcoon opened this issue Dec 9, 2018 · 10 comments · Fixed by #2680
Assignees
@gibbsfromncis
Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5b] Small Indicates size of task. Est. between one and two hours [6] Style Guide Impact flag identifying related to a Style Guide [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Milestone
190510

Comments

@startailcoon
Copy link
Contributor

The Ant Design Tooltip needs to be changed to reflect a better choice of font, font-size and design.

The background of the tooltip is floating into the background of the application. It would need a border to single it out better.

bitshares-tooltip
@startailcoon startailcoon added [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [5b] Small Indicates size of task. Est. between one and two hours [6] Style Guide Impact flag identifying related to a Style Guide [7] Estimated Administration flag, notifies hours are estimated and requires revisiting labels Dec 9, 2018
@startailcoon startailcoon added this to the 181212 milestone Dec 9, 2018
@sschiessl-bcp
Copy link
Contributor

Do you have github issue preview on?
image

@sschiessl-bcp
Copy link
Contributor

Anyways, I closed my other issue as a duplicate
#2229

@startailcoon
Copy link
Contributor Author

@sschiessl-bcp yes, but I'm still unused to having it and must have missed that one.

@startailcoon startailcoon added the [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive label Dec 15, 2018
@startailcoon startailcoon modified the milestones: 181212, 190103 Dec 15, 2018
@startailcoon startailcoon modified the milestones: 190103, 190227 Feb 14, 2019
@startailcoon
Copy link
Contributor Author

@gibbsfromncis are you working on this?

@startailcoon startailcoon modified the milestones: 190301, 190315 Mar 9, 2019
@gibbsfromncis
Copy link
Contributor

@startailcoon Nope. I'll work on it before end of this sprint

@clockworkgr clockworkgr modified the milestones: 190315, 190329 Mar 20, 2019
@clockworkgr clockworkgr modified the milestones: 190329, 190412 Apr 3, 2019
@startailcoon
Copy link
Contributor Author

@gibbsfromncis do you have a progress update?

@startailcoon startailcoon modified the milestones: 190412, 190426 Apr 14, 2019
@gibbsfromncis
Copy link
Contributor

@startailcoon will work on it today/tomorrow

@sschiessl-bcp
Copy link
Contributor

@startailcoon will work on it today/tomorrow

Happened?

@startailcoon startailcoon modified the milestones: 190426, 190510 May 4, 2019
@gibbsfromncis
Copy link
Contributor

gibbsfromncis commented May 10, 2019 •
edited
Loading

@startailcoon @sschiessl-bcp

tooltip

I've looked more deep on this issue and my position is:

  • I see no reason to change font, size or color. It is OK. It uses 14px font-size as our default size everywhere..
  • I've updated box-shadow for tooltip container and made it more stronger (check the licecap)

gibbsfromncis added a commit that referenced this issue May 10, 2019
@gibbsfromncis
#2293 Update style-guide version
f9f2a44
@gibbsfromncis gibbsfromncis mentioned this issue May 10, 2019
Merged
12 tasks
@gibbsfromncis
Copy link
Contributor

@startailcoon I've spent 1h and decreased estimate for this task

@gibbsfromncis gibbsfromncis changed the title [1.5][Style-Guide] Tooltip Layout [1][Style-Guide] Tooltip Layout May 10, 2019
sschiessl-bcp pushed a commit that referenced this issue May 10, 2019
Merge pull request #2680 from bitshares/2293-fix-tooltip
4246c47 
#2293 Update style-guide version
@sschiessl-bcp sschiessl-bcp mentioned this issue Jun 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gibbsfromncis gibbsfromncis

Labels
[1c] Task Task for team member to perform. Description may contain a Task List and reference child Sub-Tasks [3] Enhancement Classification indicating a change to the functionality of the existing imlementation [4c] High Priority Priority indicating significant impact to system/user -OR- workaround is prohibitivly expensive [5b] Small Indicates size of task. Est. between one and two hours [6] Style Guide Impact flag identifying related to a Style Guide [7] Estimated Administration flag, notifies hours are estimated and requires revisiting
Projects
None yet
Milestone
190510
Development

Successfully merging a pull request may close this issue.

#2293 Update style-guide version bitshares/bitshares-ui
4 participants
@clockworkgr @startailcoon @sschiessl-bcp @gibbsfromncis