[2][kapeer42] Exchange Vertical OrderBook Centering Issues

[startailcoon]

Describe the bug
The vertical orderbook is at times jumpy when the centering isn't updated properly. There is at times a timedelay when the orderbook is populated before the centering is issued.

To Reproduce
Steps to reproduce the behavior:

1. Go to 'Exchange'
2. Select BTS/bitCNY or any other high volume market
3. See error

Expected behavior
Centering done without visual delay

Screenshots (LiceCap, wait for it)

Desktop (please complete the following information):

• OS: W10
• Browser Light Wallet - 180629

[startailcoon]

Any progress on this @mattbeckman?

[wmbutler]

I'd suggest that we remove the centering completely and let the user scroll determine where this is positioned. Thoughts?

[mattbeckman]

Sorry, forgot I self assigned. I started work on it, and I think we should split the bid/ask/center so that we aren't trying to center vertically across a large set of rows. Separate scroll for top/bottom. I'll get a screen capture soon.

[startailcoon]

By adding the following to the code here we can handle centering much better

bitshares-ui/app/components/Exchange/OrderBook.jsx

Line 366 in 043a2d3

        if (!this.props.horizontal) {
            this.setState({autoScroll: true}, () => {
                this.psUpdate();
            });
        }

This makes this redundant in the prepending statement on line 362

[startailcoon]

@mattbeckman will you complete this issue?

I think we should just set the order book market price in the middle and have two separate columns that can be scrolled independently instead. This would remove the jumping of the middle column with the price.

Thoughts?

[wmbutler]

@startailcoon that's the way it was before, but it doesn't make a lot of sense to scroll independently since the center is where the buy and sell meet.

[startailcoon]

Right, but we need to make sure the center stay center and doesnt jump around.

Can we achieve that?

[mattbeckman]

Only had a few intermittent evenings to hit this. I couldn't solve the jump factor consistently without splitting. Pulled out StickyTable, and I have it working, but I will need to confirm it's responsive.

[wmbutler]

@mattbeckman can you sneak this into the current sprint?

[kapeer42]

Can I claim this?

[mattbeckman]

@kapeer42 Yes, but check with @startailcoon that it's still needed. I have a branch where StickyTable was pulled out of OrderBook, but OrderBook has been refactored since then, and due to conflicts may be faster to rethink it if the issue still exists.

[startailcoon]

StickyTables are still present as before, even on the new Exchange Design, and the current issue is still present on it.

Give it your best crack @kapeer42 👍

[sschiessl-bcp]

@startailcoon
Please make sure this is also reflected in the new Exchange Design

[startailcoon]

@kapeer42 @sschiessl-bcp As it was based on the new exchange design I've cherry picked the code for PR #1875 and merged it to its branch. However, it still seems to be a slight issue with the centering, please see my comment on #1875 (comment)

[kapeer42]

@startailcoon I'm working on the issue on latest develop, will push soon

[startailcoon]

There is no specific change to that part based on the new exchange design, so I wouldn't have any issue making it work once you have it ready.

[sschiessl-bcp]

Perfect, thanks!

[sschiessl-bcp]

Perfect, thanks!