[.5][gibbsfromncis][1][svk31] No error message shows when trying to issue a big amount of asset

[abitmore]

Describe the bug
No error message shows when trying to issue a big amount of asset

To Reproduce
Steps to reproduce the behavior:

1. Go to testnet.bitshares.eu
2. Click on hamburg menu -> assets
3. Click on "Issue asset"
4. Input an account name, a big amount e.g. 1000000000000000, click "issue asset"

Expected behavior
A message should appear to indicate the action succeeded or failed

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: Win7
• Browser Chrome
• Version Latest

Additional context
Add any other context about the problem here.

[wmbutler]

We must define a "big amount" I assume. Discuss.

[abitmore]

I think we can simply show whatever error the backend has returned, if it's hard for UI to determine.

Possible reasons:

• the number itself exceeded max_supply defined in asset info
• there is already an existing supply, in this case, even adding a little more supply will cause an error

[wmbutler]

• Relay the literal error message for cases where errors were returned related to issuance.

[gibbsfromncis]

@wmbutler If you agree to increase bounty if this task take more time - I'll take it

[startailcoon]

I'm sure we can increase the hours to support this issue to be completed.

Let's increase it to two hours and track your time if it takes much more.

[gibbsfromncis]

@svk31 I've found out that I cannot catch error on bitshares-ui side. Some library returns error like this:

Do you have time to take a look on it or should I fix it by myself? If you have no time please give me some advice where to take a look on it and fix. Thx.

[svk31]

That's from bitsharesjs and the long lib, can you give me a test case to reproduce it?

[gibbsfromncis]

@svk31 Hm.. I cannot push my code to bitshares-ui directly so I've pushed to my fork: gibbsfromncis@c340305

Steps:

1. Create any asset
2. Tap "Issue Asset" on created asset and put number larger than supply
3. Submit form and you get this error.

Btw don't forget to add error handler (take a look my commit above)

Thx

[wmbutler]

Pending @svk31

[svk31]

The overflow error happens before trying to process the transaction, that's why you can't catch it. I've made some minor changes to how the issue asset method is used and handles errors, for now it just pops up a notification that the asset issue failed.

[gibbsfromncis]

@svk31 Do I understand correct that you already fixed this bug and I should just unassign myself and assign you?

[svk31]

I just investigated the error catching you pointed out, and once fixed I simply moved the existing error message to the correct location.

I guess that did fix the issue, in that case the hour estimate was too high, only took me 45mins or so. You probably spent some time on this as well though so we can add that.

[gibbsfromncis]

@svk31 I've assigned you to this issue and splitted hours between both of us. I suppose it would be fair. Is you have any other suggestions please let me know. I closed this issue