Merge pull request #253 from bitshares/revert-250-update-unpack-stati…

…c-variant Revert "Avoid potential corruption during unpack of static_variant"
bitshares · Feb 6, 2024 · fe9f7e1 · fe9f7e1
2 parents 4dc64ba + e820266
commit fe9f7e1
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/include/fc/io/raw.hpp b/include/fc/io/raw.hpp
@@ -889,9 +889,8 @@ namespace fc {
        --_max_depth;
        unsigned_int w;
        fc::raw::unpack( s, w, _max_depth );
-       static_variant<T...> helper( static_cast<typename static_variant<T...>::tag_type>(w.value) );
-       helper.visit( unpack_static_variant<Stream>( s, _max_depth ) );
-       sv = helper;
+       sv.set_which(w.value);
+       sv.visit( unpack_static_variant<Stream>( s, _max_depth ) );
     }
 
 } } // namespace fc::raw