Add missing is_virtual field in account history in ES, and fix a related API
#2730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abitmore
force-pushed
the
is-virtual-field-in-es
branch
from
d8a1852
to
778fa64
Compare
Data in these fields was missing from the return value: * is_virtual * block_time
abitmore
changed the title
is_virtual field in account history in ESis_virtual field in account history in ES, and fix related API
abitmore
force-pushed
the
is-virtual-field-in-es
branch
from
8053026
to
bfa0401
Compare
|
Kudos, SonarCloud Quality Gate passed! |
abitmore
changed the title
is_virtual field in account history in ES, and fix related APIis_virtual field in account history in ES, and fix a related API
abitmore
modified the milestones:
7.1.0 - Feature Release,
7.0.0 - Protocol Upgrade Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues:
is_virtualfield inoperation_history_object, but forgot to save it to the ElasticSearch database.elasticsearch_plugin::get_account_history()is missing data inis_virtualfield andblock_timefields (introduced in Add block_time and is_virtual fields to operation_history_object #2642 too).