Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undercollateralized short positions should be called regardless of asks #606

Closed
abitmore opened this issue Jan 29, 2018 · 1 comment
Closed

Undercollateralized short positions should be called regardless of asks #606

abitmore opened this issue Jan 29, 2018 · 1 comment
Assignees
@abitmore
Labels
bug hardfork
Milestone
201806 - Consensu...

Comments

@abitmore
Copy link
Member

See these screenshots for example:

There is one bitCNY short position whose collateral ratio is below 175%. However, because there are asks (selling CNY for BTS) with price (x BTS per CNY) lower than the feed price (named "settlement" on the screenshot), according to current rule, the short position is not margin called, instead, it shows a yellow price which is much higher than market price hanging on the order book. I think the short position should be matched with the top asks.

More discussion is here: https://bitsharestalk.org/index.php/topic,25886.0.html
@abitmore abitmore added this to the 201803 - Consensus Changing Release milestone Jan 29, 2018
@abitmore abitmore self-assigned this Jan 29, 2018
@abitmore abitmore mentioned this issue Feb 2, 2018
Closed
abitmore added a commit that referenced this issue Feb 3, 2018
@abitmore
Market engine improvements.
bba18da 
For:
* #338 Margin call order fills at price of matching limit_order
* #343 Inconsistent sorting of call orders between matching against a limit order and a force settle order
* #453 Multiple limit order and call order matching issue
* #606 Undercollateralized short positions should be called regardless of asks
This was referenced Feb 3, 2018
Merged
Closed
abitmore added a commit that referenced this issue Feb 6, 2018
@abitmore
Test case reproduces #338 #343 #453 #606 #625 #649
c58d00b
abitmore added a commit that referenced this issue Feb 7, 2018
@abitmore
Test case for #338 #343 #453 #606 #625 #649 fixes
1a68c32
abitmore added a commit that referenced this issue Feb 8, 2018
@abitmore
Add cross-hardfork tests #338 #343 #453 #606 #649
a8a0245
abitmore added a commit that referenced this issue Feb 8, 2018
@abitmore
Skip checking call orders on manually cancel #606
eda3b66
abitmore added a commit that referenced this issue Feb 8, 2018
@abitmore
Skip checking calls on limit order expiration #606
aa9c22a
@abitmore abitmore mentioned this issue Feb 18, 2018
Merged
abitmore added a commit that referenced this issue Apr 7, 2018
@abitmore
Test case reproduces #338 #343 #453 #606 #625 #649
10298ca
abitmore added a commit that referenced this issue Apr 7, 2018
@abitmore
Market engine improvements.
b2a86dd 
For:
* #338 Margin call order fills at price of matching limit_order
* #343 Inconsistent sorting of call orders between matching against a limit order and a force settle order
* #453 Multiple limit order and call order matching issue
* #606 Undercollateralized short positions should be called regardless of asks
abitmore added a commit that referenced this issue Apr 7, 2018
@abitmore
Skip checking call orders on manually cancel #606
3f699c1
abitmore added a commit that referenced this issue Apr 7, 2018
@abitmore
Skip checking calls on limit order expiration #606
29925b1
abitmore added a commit that referenced this issue Apr 7, 2018
@abitmore
Test case for #338 #343 #453 #606 #625 #649 fixes
e5fc5d4
abitmore added a commit that referenced this issue Apr 7, 2018
@abitmore
Add cross-hardfork tests #338 #343 #453 #606 #649
a8391d8
@abitmore abitmore mentioned this issue Apr 7, 2018
Merged
@abitmore
Copy link
Member Author

Done with #829.

@abitmore abitmore mentioned this issue May 11, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abitmore abitmore

Labels
bug hardfork
Projects
None yet
Milestone
201806 - Consensus Changing Release
Development

No branches or pull requests
2 participants
@pmconrad @abitmore