Do not log sensitive command params when Apple ID authentication fails #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
changed the title
tothszabi
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR/MINOR/PATCH version update
Context
Pulls in updated bitrise-io/go-xcode#221.
We logged potential secrets due to using the v2/command package: https://github.com/bitrise-io/go-utils/blob/921272de13f5811b3a22dcd883459ea472c7f461/command/command.go#L172.
Apple ID authentication failed: The input stream is exhausted., error: command failed with exit status 1 (bundle "exec" "ruby" "main.rb" "--subcommand" "list_dev_certs" "--username" "myemail@gmail.com" "--password" "my-readable-password" "--session"Fixed this by omitting the error returned by v2/command.
Resolves: #328
https://bitrise.atlassian.net/browse/SSW-1144
Changes
Investigation details
Decisions