-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step 1840 remove xamarin support #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have much of knowledge of the codesign tool itself so I mainly validated the code changes only. It looks good to me because they were mainly typo fixes, removal of xamarin logic and minor leave the codebase in a better place than you have found it
type of changes.
@@ -21,8 +21,7 @@ import ( | |||
|
|||
var xcodeUITestsCmd = &cobra.Command{ | |||
Use: "xcodeuitests", | |||
Short: "Xcode project scanner for UI tests", | |||
Long: `Scan an Xcode project for UI test targets`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Long
value has some meaningful information of what this command does. I like the Short
value update but do not we want to keep the Long
one somehow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short is the command description when the command is listed as a subcommand. Long is the main description (Short gets used as the main description if Long is not provided).
Updated the Short and Long descriptions, now it looks like:
$ codesigndoc scan -h
Scans the project's code signing settings,
and exports the required code signing files.
Usage:
codesigndoc scan [command]
Available Commands:
xcode Scans the project's code signing settings for Xcode Archive and IPA export actions
xcodeuitests Scans the project's code signing settings for Xcode Build For Testing action
Flags:
...
and
$ codesigndoc scan xcode -h
Scans the project's code signing settings for Xcode Archive and IPA export actions
and exports the required code signing files.
Usage:
codesigndoc scan xcode [flags]
Flags:
...
and
$ codesigndoc scan xcodeuitests -h
Scans the project's code signing settings for Xcode Build For Testing action
and exports the required code signing files.
Usage:
codesigndoc scan xcodeuitests [flags]
Flags:
...
func FindCertificate(nameOrSHA1Fingerprint string, certificates []certificateutil.CertificateInfoModel) (certificateutil.CertificateInfoModel, error) { | ||
for _, certificate := range certificates { | ||
if certificate.CommonName == nameOrSHA1Fingerprint { | ||
return certificate, nil | ||
} | ||
if strings.ToLower(certificate.SHA1Fingerprint) == strings.ToLower(nameOrSHA1Fingerprint) { | ||
if strings.EqualFold(certificate.SHA1Fingerprint, nameOrSHA1Fingerprint) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about strings.EqualFold
Version
Requires a MAJOR version update
Context
This PR removes Xamarin support from codesigndoc.
Supports: bitrise-io/bitrise-add-new-project#64
Changes
go-xcode
to resolve Xcode version parsing on M1bitrise-init