-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error "Imported page does not exist" #99
Comments
@liayn Thanks for reporting! Maybe |
Ceveat: A template with multiple pages will only use the first page of it Fixes bithost-gmbh#99
I pushed a very dirty workaround, which fulfills at least our current needs |
Ceveat: A template with multiple pages will only use the first page of it Fixes bithost-gmbh#99
I actually think that it is a good fix for that issue. I had a closer look at FPDI, there is no way to determine the most recently used template anymore, thus we have to keep that information in our own class. However I changed the implementation to not rely on an additional method, because I think this is less error-prone. I also added functional tests covering that issue. pdfviewhelpers/Classes/Model/BasePDF.php Lines 214 to 219 in e6d1b73
Thanks again for your contribution! If you like the project, please consider giving it a star :) |
This error occurs using latest version from TER 2.0.1 when using
sourceFile
andimportPage
and when a PDF is created containing multiple pages. This issue is probably related to #41.One problem is that there is broken code in
https://github.com/bithost-gmbh/pdfviewhelpers/blob/master/Classes/Model/BasePDF.php#L199
$this->tpl
is never defined. A strict comparison against0
is alwaystrue
. This leads to calling$this->useTemplate(NULL);
, subsequently causing the mentioned error.The text was updated successfully, but these errors were encountered: