Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more compatibility with PHP 5.4 #17

Closed
Oktopuce opened this issue Mar 15, 2017 · 9 comments
Closed

No more compatibility with PHP 5.4 #17

Oktopuce opened this issue Mar 15, 2017 · 9 comments
Assignees
Labels

Comments

@Oktopuce
Copy link

Hi,

The last version of the extension is no more compatible with PHP 5.4 because of this line :

$this->configurationManager = GeneralUtility::makeInstance(ConfigurationManager::class);

in 5.4 you can use this :

$this->configurationManager = GeneralUtility::makeInstance(\get_class(new \TYPO3\CMS\Extbase\Configuration\ConfigurationManager));

Reagrds,
Florian

@maechler
Copy link
Member

Hi @Oktopuce

Thanks for reporting that issue! We will fix it soon and release a new version!

@maechler maechler self-assigned this Mar 16, 2017
@maechler maechler added the bug label Mar 16, 2017
@Oktopuce
Copy link
Author

Hi,

There is another compatibility problem the extension cannot be installed on Typo3 6.2.0 because there is a problem with the composer :

Oops, an error occurred!
The package "pdfviewhelpers" depends on "typo3/cms" which is not present in the system.

Florian

@Oktopuce
Copy link
Author

I found this solution for composer : change the package name from typo3/cms to typo3/cms-cms.

@maechler
Copy link
Member

@Oktopuce That seems a little strange to me, especially since there is no composer package typo3/cms-cms. The official TYPO3 composer package name is typo3/cms found here.

When exactly does that error occur?

@Oktopuce
Copy link
Author

This occurred when I tried to install the version 1.2.0 on a typo3 6.2.0.
I found that solution on the web and didn't look further but may be it's "typo3/cms-core" instead of "typo3/cms-cms".

Look here : https://review.typo3.org/#/c/35501/2/composer.json

@maechler
Copy link
Member

As far as I can see is typo3/cms-core now part of the package typo3/cms. See https://github.com/TYPO3/TYPO3.CMS/blob/master/composer.json#L92
There is also no package typo3/cms-core on packagist.org.

I also tested installing the extension on TYPO3 6.2.16 using the extension manager, that worked for me.

Do you install it with the extension manager or via composer? What commands do you use? Have you tested it with a fresh installation of TYPO3 6.2? What could I do to reproduce the issue?

@Oktopuce
Copy link
Author

I installed it via the Extension Manager. I didn't test it on a fresh installation.

@maechler
Copy link
Member

maechler commented Mar 16, 2017

Hmm..I could not reproduce that issue. Although I can not yet fully grasp the problem or the way TYPO3 handles the composer.json files, I think the dependency should be typo3/cms-core as you suggested.
See also https://wiki.typo3.org/Composer or https://composer.typo3.org/.

@maechler
Copy link
Member

I fixed these issues and created a new release. Soon the extension will be available in TER.
I will close here, thanks for reporting the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants