Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 2024 Q2 update blog post #189

Merged

Conversation

thunderbiscuit
Copy link
Member

@thunderbiscuit thunderbiscuit commented Aug 9, 2024

I used to have a workflow to build the site locally but it doesn't work anymore so I don't have a way to test this. Pushing here so I can see the preview.

Edit: ok it's not just on my machine.

So the key is to add

function capitalize(str) {
  return str.charAt(0).toUpperCase() + str.slice(1);
}

To the node_modules/@spiralbtc/vuepress-devkit-theme/config.js file to enable it to build locally. For deployment, we'd need to update the theme itself, but I can't find the github link! @dennisreimann any ideas?

Copy link

netlify bot commented Aug 9, 2024

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit b6eaaf2
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/66ba26f4c250bd000735a581
😎 Deploy Preview https://deploy-preview-189--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thunderbiscuit
Copy link
Member Author

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cfb9c26

ACKing because the text of this looks good, even though I see CI is failing and your comment and that I can't see a preview of this yet.

Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cfb9c26

@thunderbiscuit thunderbiscuit force-pushed the feature/2024-q2-update branch 2 times, most recently from 2b5d608 to 6a86ee2 Compare August 9, 2024 19:40
@thunderbiscuit
Copy link
Member Author

@dennisreimann actually after rebasing on your PR, I still get the error, even though our package-lock shows

"@spiralbtc/vuepress-devkit-theme": "^0.19.0",

@dennisreimann
Copy link
Collaborator

@thunderbiscuit You are correct, the reference for the capitalize function was indeed missing from the theme config. I'm not sure why the error comes upin context of this PR only, but it must have something to do with the pagination, where capitalize gets used.

However, I've updated the theme and used the new version here, now the build and preview work again. Blog post preview here: https://deploy-preview-189--awesome-golick-685c88.netlify.app/blog/_2024-q2-update/

@thunderbiscuit
Copy link
Member Author

Sweet thanks @dennisreimann!

@thunderbiscuit thunderbiscuit force-pushed the feature/2024-q2-update branch 2 times, most recently from d84b990 to 5b8bcf1 Compare August 12, 2024 15:12
@thunderbiscuit thunderbiscuit merged commit b6eaaf2 into bitcoindevkit:master Aug 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants