Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for regenerating ids #103

Merged
merged 27 commits into from
Sep 6, 2023
Merged

Conversation

eth0net
Copy link
Contributor

@eth0net eth0net commented Sep 3, 2023

Description

This adds support for regenerating the id for a category, entity, or property. It also adds the ability to regenerate ids for all pandora items at once, to aid with migration from sequential ids to nanoids.

Addressed issues

  • none

Screenshots

image
image

@eth0net
Copy link
Contributor Author

eth0net commented Sep 3, 2023

One flaw right now: the list won't automatically update tooltips with the new IDs. They do update after a save and reload of items using the Pandora toolbar.

@eth0net
Copy link
Contributor Author

eth0net commented Sep 3, 2023

One flaw right now: the list won't automatically update tooltips with the new IDs. They do update after a save and reload of items using the Pandora toolbar.

Fixed using _populate_data(), though this does cause the selected entry to be de-selected, which seems unnecessary.

@eth0net
Copy link
Contributor Author

eth0net commented Sep 3, 2023

There were some whitespace changes done by Godot, so worth hiding whitespace when reviewing :)

@bitbrain
Copy link
Owner

bitbrain commented Sep 3, 2023

A few things we may want to add:

  • unit tests
  • some basic docs of what the purpose of this functionality is (e.g. use cases, examples)

@bitbrain
Copy link
Owner

bitbrain commented Sep 6, 2023

Thank you! Great PR.

@bitbrain bitbrain merged commit f84e70b into bitbrain:godot-4.x Sep 6, 2023
3 checks passed
@eth0net eth0net deleted the id-regen branch September 26, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants