New option in PhoneNumberValidator to enforce exact number of digits #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now, national phone numbers worldwide just had to be between 5-12 digits long to pass validation. However, many countries have a specific number of of digits in all their phone numbers which is very well known (EX: all USA numbers are 10 digits long). So this change adds an optional parameter to specify how many digits must be in the phone number for it to validate. Uncommited changes will also use this new capability, provided this pull request is adopted.
Original commit omitted the new display string used by this new feature. Additionally, added two unittests to verify the code changes in this pull request work and do not break existing functionality.
cparke2
commented
Sep 21, 2024
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
HenrikJannsen
requested changes
Sep 22, 2024
| * Required length of phone number (excluding country code). | ||
| */ | ||
| @Getter | ||
| private int requiredLength; |
There was a problem hiding this comment.
As it is optional I would suggest to use an Optional type instead.
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
desktop/src/main/java/bisq/desktop/util/validation/PhoneNumberValidator.java
Outdated
Show resolved
Hide resolved
Created new class PhoneNumberRequiredLengths.java with a Map lookup for the requiredlength of phone numbers in select countries that are well-known to have uniform fixed-length phone number throughout. Country codes missing will continue to use just the previous length-range algorithms. Lookup into this Map is integrated into PhoneNumberValidator.java, no longer needed an overloaded constructor to provide this functionality.
Created new class PhoneNumberRequiredLengths.java with a Map lookup for the requiredlength of phone numbers in select countries that are well-known to have uniform fixed-length phone number throughout. Country codes missing will continue to use just the previous length-range algorithms. Lookup into this Map is integrated into PhoneNumberValidator.java, no longer needed an overloaded constructor to provide this functionality. [New .java file was accidentally omitted from previous commit]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, national phone numbers worldwide just had to be between 5-12 digits long to pass validation. However, many countries have a specific number of of digits in all their phone numbers which is very well known (EX: all USA numbers are 10 digits long). So this change adds an optional parameter to specify how many digits must be in the phone number for it to validate. Uncommited changes will also use this new capability, provided this pull request is adopted.